Browse Source

Make sure to set comments on fresh failing tests.

master
Ben Kurtovic 8 years ago
parent
commit
1671f306d0
1 changed files with 3 additions and 2 deletions
  1. +3
    -2
      lib/kgrader/submission.rb

+ 3
- 2
lib/kgrader/submission.rb View File

@@ -120,7 +120,8 @@ module KGrader
def grade_prep(superscore) def grade_prep(superscore)
@done = false @done = false
@failed = false @failed = false
@changed = !superscore || self.status == :ungraded
@fresh = self.status == :ungraded
@changed = !superscore || @fresh
@summary = nil @summary = nil
@tests = @assignment.tests.clone.each do |test| @tests = @assignment.tests.clone.each do |test|
test[:score] = 0 test[:score] = 0
@@ -205,7 +206,7 @@ module KGrader
end end


score, comments = @fs.jail.run_test test[:script], testlog score, comments = @fs.jail.run_test test[:script], testlog
if score > test[:score]
if score > test[:score] || (score == test[:score] && @fresh)
test[:score] = score test[:score] = score
test[:comments] = comments test[:comments] = comments
@changed = true @changed = true


Loading…
Cancel
Save